Re: pgsql: Cache by-reference missing values in a long lived context

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Cache by-reference missing values in a long lived context
Date: 2023-08-24 15:27:01
Message-ID: 3907902.1692890821@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
> Cache by-reference missing values in a long lived context

The v11 version of this patch is causing a compiler warning for me:

In file included from heaptuple.c:58:
heaptuple.c: In function 'missing_hash':
heaptuple.c:97:3: warning: implicit declaration of function 'hash_any'; did you mean 'hash_stats'? [-Wimplicit-function-declaration]
hash_any((const unsigned char *) entry->value, entry->len));
^~~~~~~~
../../../../src/include/postgres.h:471:38: note: in definition of macro 'DatumGetUInt32'
#define DatumGetUInt32(X) ((uint32) (X))
^

It seems to work anyway, but please fix.

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2023-08-24 16:03:16 pgsql: Avoid unnecessary plancache revalidation of utility statements.
Previous Message Alvaro Herrera 2023-08-24 14:52:28 pgsql: Add test for inherited CHECK constraint drop