From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
---|---|
To: | Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> |
Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: some more error location support |
Date: | 2018-08-29 13:08:46 |
Message-ID: | 38f26c49-c820-5173-8b62-b8afa5ffe591@2ndquadrant.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 28/08/2018 08:58, Fabien COELHO wrote:
>
>>> Even if there is some under-the-hood garbage collection, I'd suggest to
>>> add a free after the call to ComputePartitionAttrs.
>>
>> Hmm, I didn't know about free_parsestate(). It doesn't seem to be used
>> consistently. I suppose you'll want to use it when you have a target
>> relation that will be closed by it, but otherwise, for DDL commands,
>> it's not all that useful.
>
> Probably.
>
> The majority rule (34 make & 22 free) suggest that it is more often use
> than not. I'd suggest to stick to that for consistency & homogeneity.
But it's consistently not used in DDL command implementations, only in
normal query parsing.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
From | Date | Subject | |
---|---|---|---|
Next Message | Peter Eisentraut | 2018-08-29 13:11:50 | Re: some more error location support |
Previous Message | Alexander Kukushkin | 2018-08-29 13:05:25 | Re: BUG #15346: Replica fails to start after the crash |