Re: BUG #16931: source code problem about commit_ts

From: Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>
To: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
Cc: zoulx1982(at)163(dot)com, pgsql-bugs(at)lists(dot)postgresql(dot)org
Subject: Re: BUG #16931: source code problem about commit_ts
Date: 2021-03-24 10:25:54
Message-ID: 38d5b3c4-3bbf-64be-69f5-5f50cd1f6c2d@oss.nttdata.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

On 2021/03/24 18:05, Alvaro Herrera wrote:
> Yeah, it seems like a bug. With your patch, the write_xlog=true path
> becomes unused, and thus the whole COMMIT_TS_SETTS record, so we could
> remove those things in branch master. The timestamp is acquired from
> the COMMIT record.

I agree to remove COMMIT_TS_SETTS record from the master branch
if there are no users or extensions of it. Patch attached.

Anyway, at first, what about applying the bugfix patch I posted upthread
to all supported branches?

Regards,

--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION

Attachment Content-Type Size
v1_remove_commit_ts_setts.patch text/plain 7.2 KB

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Mundla, Sankar 2021-03-24 11:09:03 After upgrade from version9.4.1 to 10.15, changes on the table structure
Previous Message Alvaro Herrera 2021-03-24 09:05:19 Re: BUG #16931: source code problem about commit_ts