Re: BUG #17994: Invalidating relcache corrupts tupDesc inside ExecEvalFieldStoreDeForm()

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Andres Freund <andres(at)anarazel(dot)de>, exclusion(at)gmail(dot)com, pgsql-bugs(at)lists(dot)postgresql(dot)org
Subject: Re: BUG #17994: Invalidating relcache corrupts tupDesc inside ExecEvalFieldStoreDeForm()
Date: 2023-07-01 13:14:39
Message-ID: 3878b204-e9b4-6e09-9adb-7a37b8db34a6@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs


On 2023-06-30 Fr 15:08, Tom Lane wrote:
> Andrew Dunstan<andrew(at)dunslane(dot)net> writes:
>> Me either. I think this might call for too much invention so I'm going
>> to revert to plan A. The invalidation code won't be very much, and it
>> should be a fairly rare event, so it doesn't need to be very clever.
> The problem with rarely-executed code is that it's also hard to test.
>
>

Your Plan B in the end proved less difficult than I thought, and
certainly seems more robust than having to tangle with invalidations. I
didn't try to do anything to wrap the values in a bytea, it didn't seem
necessary. Here's a patch - it's not terribly long or invasive. I
haven't tried backpatching it yet.

cheers

andrew

--
Andrew Dunstan
EDB:https://www.enterprisedb.com

Attachment Content-Type Size
fix-missing-value-corruption.patch text/x-patch 4.8 KB

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message ess.bee59 2023-07-01 14:37:36 BUG #18005: PSQL Process hangs in parallel mode / complement information
Previous Message PG Bug reporting form 2023-07-01 07:54:03 BUG #18011: Declarative partition privilege problem cause incorrect execution plans