Re: Thread-safe nl_langinfo() and localeconv()

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Peter Eisentraut <peter(at)eisentraut(dot)org>
Cc: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Thread-safe nl_langinfo() and localeconv()
Date: 2025-03-31 13:52:44
Message-ID: 3872809.1743429164@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Peter Eisentraut <peter(at)eisentraut(dot)org> writes:
> I'm not sure what to do with this. If setlocale() and newlocale()
> indeed behave differently in what set of locale names they accept, then
> technically we ought to test both of them, since we do use both of them
> later on. Or maybe we push on with the effort to get rid of setlocale()
> calls and then just worry about testing newlocale() (as this patch
> does). But right now, if newlocale() is more permissive, then we could
> accept locale names that will later fail setlocale() calls, which might
> be a problem.

I think the clear answer is "let's stop using setlocale(), and then
not have to worry about any behavioral differences".

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Yugo NAGATA 2025-03-31 13:55:06 Re: Add a function to get the version of installed extension
Previous Message Yugo Nagata 2025-03-31 13:45:02 Re: Change log level for notifying hot standby is waiting non-overflowed snapshot