Re: pgsql: Inline CRC computation for small fixed-length input on x86

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: John Naylor <johncnaylorls(at)gmail(dot)com>
Cc: Andres Freund <andres(at)anarazel(dot)de>, pgsql-committers(at)lists(dot)postgresql(dot)org, cookt(at)blackduck(dot)com
Subject: Re: pgsql: Inline CRC computation for small fixed-length input on x86
Date: 2025-03-31 13:33:48
Message-ID: 3871155.1743428028@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

I wrote:
>> What I conclude is that Red Hat hot-wired gcc to assume -msse4.2,
>> but they didn't hot-wire clang the same way.

> In confirmation of that: everything goes through fine if I manually
> add -msse4.2 to configure's choice of BITCODE_CFLAGS.

Also, possibly useful for testing purposes: I can reproduce the
build failure on RHEL8, and probably elsewhere, with

./configure CFLAGS="-O2 -msse4.2" --with-llvm

In this form it's clearly pilot error, because I didn't do anything
to put -msse4.2 into CXXFLAGS. But this is another way of confirming
that the underlying problem is different default -m switches between
gcc and clang. I'm kind of surprised we have not gotten bitten by
that before.

regards, tom lane

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Eisentraut 2025-03-31 14:58:18 pgsql: doc: Mention clock synchronization recommendation for hot_standb
Previous Message Tom Lane 2025-03-31 13:09:06 Re: pgsql: Inline CRC computation for small fixed-length input on x86