| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Justin Pryzby <pryzby(at)telsasoft(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: typos |
| Date: | 2023-02-09 06:36:48 |
| Message-ID: | 3841395.1675924608@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Michael Paquier <michael(at)paquier(dot)xyz> writes:
> On Wed, Feb 08, 2023 at 09:56:44AM -0600, Justin Pryzby wrote:
>> Some more accumulated/new typos.
> 0005 can indeed fix a lot of confusion around the spaces after an
> "else if" block. Is that something that could be automated with the
> indentation, though? Same remark for 0009 and 0010.
I see your point about 0005, but I've never seen pgindent remove
vertical whitespace once it's been added. Not sure what it'd take
to teach it to do so, or whether we'd like the results.
I'd reject 0009 and 0010 altogether --- they don't add any readability
that's worth the potential increase in back-patch problems.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bharath Rupireddy | 2023-02-09 06:51:51 | Re: Introduce a new view for checkpointer related stats |
| Previous Message | Masahiko Sawada | 2023-02-09 06:32:01 | Re: Assertion failure in SnapBuildInitialSnapshot() |