Re: Compiling warnings on old GCC

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Richard Guo <guofenglinux(at)gmail(dot)com>
Cc: David Rowley <dgrowleyml(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Compiling warnings on old GCC
Date: 2023-11-06 14:47:44
Message-ID: 3830161.1699282064@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Richard Guo <guofenglinux(at)gmail(dot)com> writes:
> On Mon, Nov 6, 2023 at 2:51 PM David Rowley <dgrowleyml(at)gmail(dot)com> wrote:
>> There's some relevant discussion in
>> https://postgr.es/m/flat/20220602024243.GJ29853%40telsasoft.com

> It seems that the controversial '-Og' coupled with the old GCC version
> (4.8) makes it not worth fixing. So please ignore this thread.

Although nobody tried to enunciate a formal policy in the other thread,
I think where we ended up is that we'd consider suppressing warnings
seen with -Og, but only with reasonably-modern compiler versions.
For LTS compilers we are only going to care about warnings seen with
production flags (i.e., -O2 or better).

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message David Steele 2023-11-06 14:48:56 Re: Add recovery to pg_control and remove backup_label
Previous Message Aleksander Alekseev 2023-11-06 14:38:00 Re: XID formatting and SLRU refactorings (was: Add 64-bit XIDs into PostgreSQL 15)