Re: Clang function pointer type warnings in v14, v15

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Clang function pointer type warnings in v14, v15
Date: 2024-07-06 02:35:55
Message-ID: 382674.1720233355@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Thomas Munro <thomas(dot)munro(at)gmail(dot)com> writes:
> REL_14_STABLE and REL_15_STABLE have commit de8feb1f3, which turned on
> -Wcast-function-type, but don't have commit 101c37cd, which disabled
> -Wcast-function-type-strict as we agreed to do[1]. I noticed this on
> my local system that has clang 18 as compiler, but you can see it on
> any build farm animal using clang 16+.

> So I propose to back-patch 101c37cd to those two branches.

+1. I see that there are a boatload of related warnings in older
branches too; do we want to try to do anything about that? (I doubt
code changes would be in-scope, but maybe adding a -Wno-foo switch
to the build flags would be appropriate.)

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2024-07-06 02:37:38 Re: Wrong results with grouping sets
Previous Message Bruce Momjian 2024-07-06 02:34:49 Re: Unknown annotation '-cim' in source code