Re: TopPlan, again

Mark Kirkwood <markir(at)paradise(dot)net(dot)nz> writes:
> Gavin Sherry wrote:
>> On Sun, 18 Feb 2007, Tom Lane wrote:
>>> Comments, objections? Also, any thoughts about the names to use for
>>> these new node types? As I commented last year, I'm not completely
>>> happy with "TopPlan" because it won't actually be a subtype of Plan,
>>> but I don't have a better idea. Also I'm unsure what to call the
>>> cut-down RangeTblEntry struct; maybe RunTimeRangeTblEntry?
>>
>> I think TopPlan is misleading. What about MetaPlan instead of TopPlan? I
>> think RunTimeRangeTblEntry is okay, though long. ExecRangeTblEntry?

> Would ExecPlan be better? - matches ExecRangeTblEntry.

Neither of these seem to answer my worry that the node isn't a
subtype of "Plan".

One thought is that in some contexts this node type will probably appear
in lists that might also contain utility statement nodes. (Currently,
we represent such lists as Query lists that might or might not have
utilityStmt set, but I don't want a utilityStmt field in this node
type.) So maybe we should pick something based off "statement".
Perhaps "PlannedStmt" or "ExecutableStmt"?

ExecRangeTblEntry sounds good to me for the other thing.

regards, tom lane