| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Matthias van de Meent <boekewurm+postgres(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi> |
| Subject: | Re: BufmgrCommit no-op since 2008, remaining uses? |
| Date: | 2023-03-29 12:12:05 |
| Message-ID: | 3805003.1680091925@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Matthias van de Meent <boekewurm+postgres(at)gmail(dot)com> writes:
> BufmgrCommit does exactly nothing; it is an empty function and has
> been since commit 33960006 in late 2008 when it stopped calling
> smgrcommit().
> All two usages of the function (in our code base) seem to be in
> xact.c. Are we maintaining it for potential future use, or can the
> function be removed?
Seems reasonable. Even if bufmgr grew a new need to be called
during commit, it would quite possibly need to be called from
a different spot; so I doubt that the function is useful even
as a placeholder.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dave Cramer | 2023-03-29 12:17:48 | Re: Request for comment on setting binary format output per session |
| Previous Message | Tom Lane | 2023-03-29 11:55:43 | Re: [PATCH] Allow Postgres to pick an unused port to listen |