| From: | Brendan Jurd <direvus(at)gmail(dot)com> |
|---|---|
| To: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: WIP: to_char, support for EEEE format |
| Date: | 2009-04-26 01:38:22 |
| Message-ID: | 37ed240d0904251838v2b158f0bvfb604041afffd933@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sat, Apr 11, 2009 at 3:51 AM, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> wrote:
> So, please, if you can, propose these error messages (with hints)-
> result will be much better.
>
Hi Pavel, hackers.
I've done some work updating Pavel's sci notation patch for to_char().
I've attached a patch against HEAD (EEEE_2.diff.bz2) and against
Pavel's patch as originally submitted to the list
(EEEE_1-to-2.diff.bz2).
A summary of my changes:
* Improve the wording of error messages, and add some detail/hint parts.
* Update the documentation.
* Move the duplicated "one digit before decimal point" test into a macro.
* Fix a bug in the int8_to_char() implementation (was using the wrong
variable).
Hope you find this useful.
Cheers,
BJ
| Attachment | Content-Type | Size |
|---|---|---|
| EEEE_2.diff.bz2 | application/x-bzip2 | 3.2 KB |
| EEEE_1-to-2.diff.bz2 | application/x-bzip2 | 2.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2009-04-26 01:49:23 | Re: HashJoin w/option to unique-ify inner rel |
| Previous Message | David Fetter | 2009-04-26 00:39:07 | Re: Randomly placed definition of S_ISDIR() in psql/copy.c |