From: | Brendan Jurd <direvus(at)gmail(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Alex Hunsaker <badalex(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: Meridiem markers (was: [BUGS] Incorrect "invalid AM/PM string" error from to_timestamp) |
Date: | 2009-01-27 06:09:19 |
Message-ID: | 37ed240d0901262209h18de77dbnbcaf0079a6203e8a@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Tue, Jan 27, 2009 at 3:25 PM, Brendan Jurd <direvus(at)gmail(dot)com> wrote:
> On Tue, Jan 27, 2009 at 3:05 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>>
>> strncpy is generally deprecated; any remaining uses you find of it
>> are probably only there for lack of round tuits. Use strlcpy in new
>> code, unless there's a pretty strong argument that strncpy is actually
>> clearer for a given usage.
>>
>
> Thanks for clearing that up Tom. I will update the patch to use
> strlcpy shortly.
>
Okay, I've attached a new version of the patch with strlcpy used in
from_char_set_int_len() and from_char_seq_search(). I've also
included an incremental patch which shows the differences between
version 0 and version 1.
Cheers,
BJ
Attachment | Content-Type | Size |
---|---|---|
ampm-seqsearch_1.diff.bz2 | application/x-bzip2 | 5.5 KB |
ampm-seqsearch_0_to_1.diff | application/octet-stream | 1.5 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Heikki Linnakangas | 2009-01-27 06:15:04 | Re: 8.4 release planning |
Previous Message | Pavel Stehule | 2009-01-27 06:05:54 | Re: 8.4 release planning |