| From: | "Brendan Jurd" <direvus(at)gmail(dot)com> |
|---|---|
| To: | "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | "Alex Hunsaker" <badalex(at)gmail(dot)com>, "Joshua Tolley" <eggyknap(at)gmail(dot)com>, pgsql-bugs(at)postgresql(dot)org |
| Subject: | Re: Incorrect "invalid AM/PM string" error from to_timestamp |
| Date: | 2008-09-26 14:35:26 |
| Message-ID: | 37ed240d0809260735t70e65e53i4154b0e1f6992380@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
On Sat, Sep 27, 2008 at 12:11 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>
> Agreed on separating the message issue. What I wanted to know was
> whether there are similar bugs elsewhere in to_timestamp, or whether
> you're pretty sure this is the only occurrence of the coding pattern?
I'm pretty sure that "MS" and "US" were the only occurrences of this
particular coding pattern, and Alex's fix hits both of those.
I've just reviewed all of the sites in DCH_from_char() which advance
the pointer (with Alex's patch applied). All have the standard "s +=
SKIP_THth(n->suffix)", with the single exception of "Y,YYY", which
needs its own special logic.
Cheers,
BJ
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2008-09-26 15:36:08 | Re: Incorrect "invalid AM/PM string" error from to_timestamp |
| Previous Message | Joshua Tolley | 2008-09-26 14:15:15 | Re: Incorrect "invalid AM/PM string" error from to_timestamp |