Re: [PATCHES] to_date() validation

From: "Brendan Jurd" <direvus(at)gmail(dot)com>
To: "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: "Martijn van Oosterhout" <kleptog(at)svana(dot)org>, "Alex Hunsaker" <badalex(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: [PATCHES] to_date() validation
Date: 2008-09-11 18:12:39
Message-ID: 37ed240d0809111112i67dffe41q87d72137604bbef0@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

On Fri, Sep 12, 2008 at 3:34 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Applied with minimal modifications. I changed a couple of error
> messages that didn't seem to meet the style guidelines,

Great, thanks Tom. And thanks again to Alex and Martijn for helping
me refine the patch.

> and I moved all
> of the to_timestamp tests into horology.sql, rather than having
> essentially duplicate tests in timestamp.sql and timestamptz.sql.
>

Nice. That will make maintaining/extending the tests easier in future.

Cheers,
BJ

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2008-09-11 18:14:42 Re: Commitfest patches mostly assigned ... status
Previous Message Tom Lane 2008-09-11 17:34:55 Re: [PATCHES] to_date() validation

Browse pgsql-patches by date

  From Date Subject
Next Message Alex Hunsaker 2008-09-12 02:51:53 Re: hash index improving v3
Previous Message Tom Lane 2008-09-11 17:34:55 Re: [PATCHES] to_date() validation