From: | "Brendan Jurd" <direvus(at)gmail(dot)com> |
---|---|
To: | "Simon Riggs" <simon(at)2ndquadrant(dot)com> |
Cc: | pgsql-patches(at)postgresql(dot)org |
Subject: | Re: [HACKERS] quote_literal with NULL |
Date: | 2007-10-15 02:52:05 |
Message-ID: | 37ed240d0710141952n501e26acteb68ad9921fce26b@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers pgsql-patches |
On 10/12/07, Simon Riggs <simon(at)2ndquadrant(dot)com> wrote:
> I think you should add some examples to show how we would handle an
> INSERT or an UPDATE SET with quite_nullable() and a SELECT WHERE clause
> with quote_literal. The difference is a subtle one, which is why nobody
> mentioned it before, so it needs some better docs too.
>
> A cross-ref to the functions page would help also.
Alright, I've improved the documentation along the lines suggested by
Simon. There's a full example on doing a null-safe dynamic UPDATE, as
well as a brief discussion about being wary of using comparison
operators with NULLs (e.g., in WHERE clauses). Cross references
abound.
I did make a version of the patch which has the pg_proc entries for
quote_literal and quote_nullable both pointing to the same internal
function. I thought this was a tidier solution, but it failed
regression test #5 in opr_sanity; apparently two entries in pg_proc
can't have the same prosrc and differing proisstrict?
Cheers,
BJ
Attachment | Content-Type | Size |
---|---|---|
quote-nullable_1.diff.bz2 | application/x-bzip2 | 3.7 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Simon Riggs | 2007-10-15 05:19:56 | Re: [HACKERS] quote_literal with NULL |
Previous Message | Stephen Frost | 2007-10-14 22:16:04 | Re: rolcanlogin vs. the flat password file |
From | Date | Subject | |
---|---|---|---|
Next Message | Simon Riggs | 2007-10-15 05:19:56 | Re: [HACKERS] quote_literal with NULL |
Previous Message | Tom Lane | 2007-10-14 18:31:11 | Updated patch for tsearch contrib examples |