Re: [HACKERS] Add function for quote_qualified_identifier?

From: "Brendan Jurd" <direvus(at)gmail(dot)com>
To: "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers(at)postgresql(dot)org, pgsql-patches(at)postgresql(dot)org
Subject: Re: [HACKERS] Add function for quote_qualified_identifier?
Date: 2007-09-22 22:11:08
Message-ID: 37ed240d0709221511x44237f64n7d417b4d06579620@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

On 9/23/07, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> This seems rather pointless, since it's equivalent to
> quote_ident(schemaname) || '.' || quote_ident(relname).

Yes it is, and I brought that up in the OP:

I wrote:
> Clearly a DBA could just create this function himself in SQL (and it
> wouldn't be difficult), but is that a good reason not to have it in
> our standard set of functions?

But since nobody arced up about it I thought I might as well move
things along and produce a patch.

Many of the functions provided by postgres are easy to write yourself.
That doesn't mean they shouldn't be there. After all, there is
*exactly* one way to do quote_qualified_ident. Why require every DBA
who needs this functionality to go through the motions?

I'll admit that it's a minor improvement, but that seems reasonable
given it has a miniscule cost.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2007-09-22 23:45:24 Re: Text <-> C string
Previous Message Brendan Jurd 2007-09-22 21:55:59 Re: Text <-> C string

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2007-09-22 23:45:24 Re: Text <-> C string
Previous Message Brendan Jurd 2007-09-22 21:55:59 Re: Text <-> C string