Re: Invalid to_date patterns (was: [PATCHES] [GENERAL] ISO week dates)

From: "Brendan Jurd" <direvus(at)gmail(dot)com>
To: "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: "Bruce Momjian" <bruce(at)momjian(dot)us>, "Guillaume Lelarge" <guillaume(at)lelarge(dot)info>, "Peter Eisentraut" <peter_e(at)gmx(dot)net>, "Chad Wagner" <chad(dot)wagner(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Invalid to_date patterns (was: [PATCHES] [GENERAL] ISO week dates)
Date: 2007-07-18 00:00:44
Message-ID: 37ed240d0707171700m7c0d2905y6e69e17dd3de7960@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 7/18/07, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> This is all good but I think that self-inconsistent format strings are
> not really the main source of to_date problems. Most of the complaints
> I've seen arise from to_date plowing ahead to deliver a ridiculous
> answer when the input data string doesn't match the format. I'd like to
> see the code try a little harder to validate the input data.
>

Agreed, but so far it doesn't look like there's much overlap between
the parsing and validating code and the stuff I'm playing with.

I'll keep an eye out for any opportunities to improve on this, but it
might end up being a separate TODO.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Gregory Stark 2007-07-18 00:01:23 Re: SetBufferCommitInfoNeedsSave and race conditions
Previous Message Bruce Momjian 2007-07-17 23:48:07 Re: Restartable signals 'n all that