Uncleared result sets in describeOneTableDetails()

From: "Brendan Jurd" <direvus(at)gmail(dot)com>
To: pgsql-hackers(at)postgresql(dot)org
Subject: Uncleared result sets in describeOneTableDetails()
Date: 2006-11-07 05:41:15
Message-ID: 37ed240d0611062141x212e2bc8u1d52f63309102747@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

While I was poking around in src/bin/psql/describe.c, I noticed that
when the query for inherited tables is opened, the code checks whether
the result is valid and if not, it goes straight to the error_return,
without clearing result sets that may have been open at the time. See
line 1174 in revision 1.147.

Contrast with other instances of result sets being opened; if it
fails, the code first clears all previously opened result sets, then
goes to error_return (e.g., line 1138).

Is it crucial that result sets be cleared before going out of scope?
If so, this looks like it needs to be patched.

Regards,
BJ

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2006-11-07 06:10:46 Re: Uncleared result sets in describeOneTableDetails()
Previous Message Simon Riggs 2006-11-07 05:31:14 Re: Introducing an advanced Frequent Update Optimization