| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Autovacuum breakage from a734fd5d1 |
| Date: | 2016-11-28 02:46:53 |
| Message-ID: | 3784.1480301213@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Michael Paquier <michael(dot)paquier(at)gmail(dot)com> writes:
> In order to reproduce the failure I have just inserted a manual
> pg_usleep before looping through the list of orphan_oids, and after
> dropping manually from another session a couple of orphaned temporary
> tables I was able to see the failure. Attached is a proposal of patch.
That's not really adequate, because acquiring the lock doesn't prove that
the table still exists; you might just be holding a useless lock against
a now-unused OID. You really need to do something to verify that the
table's catalog entries are still visible after you have the lock.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2016-11-28 02:47:36 | Re: Fixed pg_class refcache leak when the meta tuple in pg_class in invalid. |
| Previous Message | Thomas Munro | 2016-11-28 02:41:44 | Re: Parallel bitmap heap scan |