Re: pgsql: Move a comment

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Peter Eisentraut <peter(at)eisentraut(dot)org>
Cc: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Move a comment
Date: 2022-07-09 15:14:25
Message-ID: 3775998.1657379665@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Peter Eisentraut <peter(at)eisentraut(dot)org> writes:
> Move a comment from the to-be-deleted section of nodes.h to where it
> might still be useful.

Hm. I'm kind of sad that we lost

- /*
- * TAGS FOR RANDOM OTHER STUFF
- *
- * These are objects that aren't part of parse/plan/execute node tree
- * structures, but we give them NodeTags anyway for identification
- * purposes (usually because they are involved in APIs where we want to
- * pass multiple object types through the same pointer).
- */

Not quite sure where that info should be put now. Maybe nodes/README
could get another para that explains what types of objects get
treated as Nodes?

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2022-07-09 17:36:33 pgsql: Mark PlanState as an abstract node type.
Previous Message Peter Eisentraut 2022-07-09 13:13:18 pgsql: Remove code sections obsoleted by node support automation