Re: Should we work around msvc failing to compile tab-complete.c?

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Dave Page <dpage(at)pgadmin(dot)org>, Andres Freund <andres(at)anarazel(dot)de>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Should we work around msvc failing to compile tab-complete.c?
Date: 2024-07-10 11:33:23
Message-ID: 376fd931-d902-4114-8ee1-466009f2793b@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


On 2024-07-10 We 5:55 AM, Dave Page wrote:
>
>
>
> What is more relevant is that as far as I can see, we've never
> actually supported either libedit or readline in MSVC++ builds - which
> kinda makes sense because Windows terminals are very different from
> traditional *nix ones. Windows isn't supported by either libedit or
> readline as far as I can see, except through a couple of forks.
>
> I imagine from mingw/cygwin builds, readline would only actually work
> properly in their respective terminals.
>

configure.ac explicitly forces --without-readline on win32, so no for
mingw. configure.ac claims there are issues especially with non-US code
pages.

One of the reasons I've continued to support building with Cygwin is
that its readline does seem to work, making its psql the best I know of
on Windows.

cheers

andrew

--
Andrew Dunstan
EDB:https://www.enterprisedb.com

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Jelte Fennema-Nio 2024-07-10 12:10:55 Re: [EXTERNAL] Re: Add non-blocking version of PQcancel
Previous Message Euler Taveira 2024-07-10 11:20:50 Re: speed up a logical replica setup