From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | John Naylor <jcnaylor(at)gmail(dot)com> |
Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: FindDefinedSymbol() is subtly broken |
Date: | 2018-05-19 20:05:48 |
Message-ID: | 3761.1526760348@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
John Naylor <jcnaylor(at)gmail(dot)com> writes:
> Long story short: It expects an array of paths, but will die if it
> can't find the symbol in the first path. Arguably it's a bug, but
> since the original use case for multiple paths is long gone anyway, it
> might never occur in practice. The attached patch changes it to expect
> a single path.
> Also attached: a few minor build script cleanups I've noticed along the way:
> -more accurate error message
> -s/print sprintf/printf/
> -a recent perltidy change made a couple multi-line strings look odd,
> so use heredocs (which other scripts use in this case anyway)
> -make generated file footers match project style
> -remove a duplicate comment
This all seemed like minor cleanup from v11 changes, so I went
ahead and pushed it rather than waiting for v12.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2018-05-19 22:31:54 | printf("%lf",...) isn't actually portable |
Previous Message | Tom Lane | 2018-05-19 17:13:00 | printf format selection vs. reality |