Re: Added prosupport function for estimating numeric generate_series rows

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: David Rowley <dgrowleyml(at)gmail(dot)com>
Cc: 孤傲小二~阿沐 <tsinghualucky912(at)foxmail(dot)com>, Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, japinli <japinli(at)hotmail(dot)com>
Subject: Re: Added prosupport function for estimating numeric generate_series rows
Date: 2024-11-28 22:44:06
Message-ID: 375710.1732833846@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

David Rowley <dgrowleyml(at)gmail(dot)com> writes:
> Also a few minor things:
> * Missing space after "if"
> + if(arg3)
> * We always have an empty line after variable declarations, that's missing in:
> + NumericVar q;
> + init_var(&q);

This sort of stuff is best addressed by running the code through
pgindent, rather than fixing it manually. Usually we don't insist
on submitters getting it right; the committer should pgindent it.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Rahila Syed 2024-11-28 23:23:57 Re: Enhancing Memory Context Statistics Reporting
Previous Message Thomas Munro 2024-11-28 22:40:21 Re: CI CompilerWarnings test fails on 15 in mingw_cross_warning