| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | David Rowley <dgrowleyml(at)gmail(dot)com> |
| Cc: | Richard Guo <guofenglinux(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Converting SetOp to read its two inputs separately |
| Date: | 2024-12-19 19:38:14 |
| Message-ID: | 374813.1734637094@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
David Rowley <dgrowleyml(at)gmail(dot)com> writes:
> On Thu, 19 Dec 2024 at 15:44, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> The common_result_slot_type() function I wrote here perhaps
>> should be made generally available, but I didn't do that yet.
> I think it would be good to make this generic as it can be at least
> used in nodeRecursiveunion.c and nodeAppend.c.
OK, done, and I added an 0006 patch that uses that infrastructure
in the obvious places.
I also addressed your remarks about comments. Otherwise I'm feeling
like this is about ready to push.
regards, tom lane
| Attachment | Content-Type | Size |
|---|---|---|
| v5-0001-Convert-SetOp-to-read-its-inputs-as-outerPlan-and.patch | text/x-diff | 74.0 KB |
| v5-0002-Remove-some-dead-code-in-prepunion.c.patch | text/x-diff | 12.5 KB |
| v5-0003-Get-rid-of-choose_hashed_setop.patch | text/x-diff | 16.9 KB |
| v5-0004-Fix-bogus-decisions-about-whether-we-want-pre-sor.patch | text/x-diff | 12.4 KB |
| v5-0005-Teach-generate_nonunion_paths-to-consider-pre-sor.patch | text/x-diff | 11.7 KB |
| v5-0006-Use-ExecGetCommonSlotOps-infrastructure-in-more-p.patch | text/x-diff | 6.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Rowley | 2024-12-19 20:36:56 | Re: Converting SetOp to read its two inputs separately |
| Previous Message | Masahiko Sawada | 2024-12-19 19:11:50 | Re: Skip collecting decoded changes of already-aborted transactions |