| From: | Nikolay Shaplov <dhyan(at)nataraj(dot)su> |
|---|---|
| To: | Alena Rybakina <a(dot)rybakina(at)postgrespro(dot)ru>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Cc: | Ilia Evdokimov <ilya(dot)evdokimov(at)tantorlabs(dot)com>, kuznetsovam(at)altlinux(dot)org, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, nickel(at)altlinux(dot)org, egori(at)altlinux(dot)org, David Rowley <dgrowleyml(at)gmail(dot)com> |
| Subject: | Re: Check for tuplestorestate nullness before dereferencing |
| Date: | 2025-04-22 11:16:27 |
| Message-ID: | 3739806.bqPgKRP4r2@thinkpad-pgpro |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
В письме от пятница, 18 октября 2024 г. 02:28:22 MSK пользователь David Rowley
написал:
> It would be good to know if the optimisation added in d2c555ee5 ever
> applies with today's code. If it does apply, we should likely add a
> test case for it and if it never does, then we should just remove the
> optimisation and always create the tuplestore when it's NULL.
That's sounds reasonable. It looks like that removing "node->eflags != 0" check
is more logical then adding not null check.
> If it does apply, we should likely add a test case for it
Do you have any idea how to test it?
--
Nikolay Shaplov aka Nataraj
Fuzzing Engineer at Postgres Professional
Matrix IM: @dhyan:nataraj.su
| From | Date | Subject | |
|---|---|---|---|
| Next Message | jian he | 2025-04-22 11:39:24 | disallow alter individual column if partition key contains wholerow reference |
| Previous Message | Tomas Vondra | 2025-04-22 10:45:55 | Re: index prefetching |