Re: [PATCH] Log crashed backend's query v2

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Florian Pflug <fgp(at)phlo(dot)org>
Cc: Marti Raudsepp <marti(at)juffo(dot)org>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Jeff Janes <jeff(dot)janes(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)commandprompt(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>
Subject: Re: [PATCH] Log crashed backend's query v2
Date: 2011-09-28 01:55:41
Message-ID: 3734.1317174941@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Florian Pflug <fgp(at)phlo(dot)org> writes:
> On Sep28, 2011, at 00:19 , Marti Raudsepp wrote:
>> (I'm still not sure what "adt" means)

> I always assumed it stood for "abstract data type".

Yeah, that's what I think too. Over time it's been used to hold most
code that is a SQL-callable function, many of which are not directly
connected to any SQL datatype. Not sure if it's worth trying to clean
that up.

Another annoying thing is that "adt" should probably have been directly
under src/backend/ --- dropping it under utils/ seems just weird for
a category that is going to hold a ton of code.

(I had once had some hope that git would allow us to move code around
more easily, but my experiments with back-patching after code movement
have convinced me that it doesn't work any better for that than CVS.
So I'm not in favor of massive code rearrangements just to make the
source tree structure cleaner.)

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Fujii Masao 2011-09-28 01:58:19 Re: Online base backup from the hot-standby
Previous Message Tom Lane 2011-09-28 01:17:29 Re: [PATCH] Addition of some trivial auto vacuum logging