Re: Patch for pg_dump: Multiple -t options and new -T option

From: "Andrew Dunstan" <andrew(at)dunslane(dot)net>
To: <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: <chriskl(at)familyhealth(dot)com(dot)au>, <pgman(at)candle(dot)pha(dot)pa(dot)us>, <dfs(at)roaringpenguin(dot)com>, <pgsql-patches(at)postgresql(dot)org>
Subject: Re: Patch for pg_dump: Multiple -t options and new -T option
Date: 2004-07-20 10:22:33
Message-ID: 3733.24.211.141.25.1090318953.squirrel@www.dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Tom Lane said:
> Christopher Kings-Lynne <chriskl(at)familyhealth(dot)com(dot)au> writes:
>> Weeeeell, I guess I'm against it based on the rules of feature freeze,
>> even though it would be really useful for me :(
>
> It would have been a lot easier to approve it if it'd arrived on June
> 30 rather than July 6 :-(. However, I do believe that David originally
> submitted a slightly-too-late version of this in the previous release
> cycle, so maybe we could cut him a little slack and pretend this is a
> mistakenly-forgotten patch that we held over from 7.4.
>
> Note I haven't actually *read* the patch and so take no position on
> whether it does what it claims to. But if someone else will read/test
> it and give it a favorable report, then I'm inclined to approve it. I'm
> quite sure we'd agreed in principle to allow multiple -t values. (A
> negative -T switch is another matter --- that part maybe needs
> more discussion.)
>

I entirely agree. Feature freeze has been said to be slightly porous, and
this is a change with relatively low impact/risk and significant benefit.

Let's not be overly rulebound.

cheers

andrew

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Dunstan 2004-07-20 10:34:33 Re: pg_config
Previous Message Harald Fuchs 2004-07-20 09:57:01 Re: pg_dump bug fixing

Browse pgsql-patches by date

  From Date Subject
Next Message Andrew Dunstan 2004-07-20 10:34:33 Re: pg_config
Previous Message Mark Kirkwood 2004-07-20 09:45:39 Re: PITR COPY Failure (was Point in Time Recovery)