Re: pgsql: Add pg_stat_archiver statistics view.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Fujii Masao <fujii(at)postgresql(dot)org>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Add pg_stat_archiver statistics view.
Date: 2014-01-28 20:28:12
Message-ID: 3720.1390940892@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fujii Masao <fujii(at)postgresql(dot)org> writes:
> Add pg_stat_archiver statistics view.
> This view shows the statistics about the WAL archiver process's activity.

For the record, this commit should certainly have included a catversion.h
bump.

Usually it's the committer's responsibility to add that when necessary;
we don't ask people to include it in submitted patches because they'd
inevitably get patch conflicts depending on what order things get
committed in.

There are a couple of rules of thumb about when to increase catversion:

* system catalog contents no longer consistent with backend executable
(in this case, pg_proc.h versus the set of functions actually present)

* regression tests would not pass without a fresh initdb (rules.out
change makes that true here)

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Andrew Dunstan 2014-01-28 22:55:43 pgsql: New json functions.
Previous Message Fujii Masao 2014-01-28 17:59:12 pgsql: Add pg_stat_archiver statistics view.