| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Abhijit Menon-Sen <ams(at)2ndquadrant(dot)com>, Andres Freund <andres(at)2ndquadrant(dot)com>, Bruce Momjian <bruce(at)momjian(dot)us>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: initdb -S and tablespaces |
| Date: | 2015-04-30 23:56:17 |
| Message-ID: | 37007.1430438177@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> On Thu, Apr 30, 2015 at 6:44 PM, Alvaro Herrera
> <alvherre(at)2ndquadrant(dot)com> wrote:
>> Ah, so that's not the duplicate code that I was remembering -- I think
>> it's walkdir() or something like that, which is in initdb IIRC.
> Yeah, walkdir() is there too. But if we're going to add that to the
> backend, I think it should go in src/backend/storage/file, not
> src/backend/access/transam.
Agreed that .../transam is a pretty horrid choice; but maybe we should
be thinking about putting it in src/common, so there's only one copy?
As for the notion that this needs to be back-patched, I would say no.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2015-05-01 00:04:42 | Re: Use outerPlanState() consistently in executor code |
| Previous Message | Robert Haas | 2015-04-30 23:50:42 | Re: Use outerPlanState() consistently in executor code |