| From: | "Jonah H(dot) Harris" <jonah(dot)harris(at)gmail(dot)com> |
|---|---|
| To: | "Alvaro Herrera" <alvherre(at)commandprompt(dot)com> |
| Cc: | "Xiao Meng" <mx(dot)cogito(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org, "Kenneth Marshall" <ktm(at)rice(dot)edu> |
| Subject: | Re: [PATCH]-hash index improving |
| Date: | 2008-07-17 17:48:32 |
| Message-ID: | 36e682920807171048u4c79c084n2e49f3230a1b508d@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Jul 17, 2008 at 12:42 PM, Alvaro Herrera
<alvherre(at)commandprompt(dot)com> wrote:
> I think having the HASHVALUE_ONLY define is not a good idea -- it just
> makes the patch harder to read. I suggest just removing the old code
> and putting the new code in place. (That's why we have revision
> control.)
Agreed. I'm also getting a crash on it with large data sets, so we'll
make sure to get those fixed in the next version of the patch.
-Jonah
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Kenneth Marshall | 2008-07-17 17:54:18 | Re: [PATCH]-hash index improving |
| Previous Message | Alvaro Herrera | 2008-07-17 17:17:53 | Re: autovacuum crash due to null pointer |