Re: Add exclusive backup deprecation notes to documentation

From: David Steele <david(at)pgmasters(dot)net>
To: Magnus Hagander <magnus(at)hagander(dot)net>, Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, Laurenz Albe <laurenz(dot)albe(at)cybertec(dot)at>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Martín Marqués <martin(at)2ndquadrant(dot)com>
Subject: Re: Add exclusive backup deprecation notes to documentation
Date: 2019-03-29 12:45:24
Message-ID: 36c2bf3c-4fb7-786c-5417-dd5e7ef98bf3@pgmasters.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 3/29/19 12:25 PM, Magnus Hagander wrote:
> On Fri, Mar 29, 2019 at 1:19 PM Robert Haas <robertmhaas(at)gmail(dot)com
> <mailto:robertmhaas(at)gmail(dot)com>> wrote:
>
> On Fri, Mar 29, 2019 at 6:27 AM David Steele <david(at)pgmasters(dot)net
> <mailto:david(at)pgmasters(dot)net>> wrote:
> > I used your suggestions with minor editing.  After some reflection, I
> > agree that the inline warnings are likely to be more effective than
> > something at the end, at least for those working on a new
> implementation.
>
> I'm glad we could agree on something.  Committed.

Me, too. Thanks!

> Minor nitpick:
> +     backup can only be taken on a primary and does not allow concurrent
> +     backups.  Moreover, because it writes a backup_label file on the
> +     master, it can cause the master to fail to restart automatically after
>
> Let's be consistent in if we call it a primary or a master, at least
> within the same paragraph :)

Agreed, let's stick with "primary".

Are we planning to back-patch this? The deprecation was added to the
docs in 9.6 -- I think these clarifications would be helpful.

Thanks,
--
-David
david(at)pgmasters(dot)net

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2019-03-29 12:46:35 Re: Add exclusive backup deprecation notes to documentation
Previous Message Robert Haas 2019-03-29 12:42:10 Re: [PG 9.6]make is failing for test_decoding contrib module.