| From: | Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> |
|---|---|
| To: | Vik Fearing <vik(at)postgresfriends(dot)org>, David Rowley <dgrowleyml(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: ANY_VALUE aggregate |
| Date: | 2023-02-22 08:56:56 |
| Message-ID: | 36c2ad45-e1d1-e024-f52d-2c11b8cb8e7a@enterprisedb.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 09.02.23 10:42, Vik Fearing wrote:
> v4 attached. I am putting this back to Needs Review in the commitfest
> app, but these changes were editorial so it is probably RfC like Peter
> had set it. I will let you be the judge of that.
I have committed this.
I made a few small last-minute tweaks:
- Changed "non-deterministic" to "arbitrary", as suggested by Maciek
Sakrejda nearby. This seemed like a handier and less jargony term.
- Removed trailing whitespace in misc.c.
- Changed the function description in pg_proc.dat. Apparently, we are
using 'aggregate transition function' there for all aggregate functions
(instead of 'any_value transition function' etc.).
- Made the tests a bit more interested by feeding in more rows and a mix
of null and nonnull values.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Heikki Linnakangas | 2023-02-22 09:08:49 | Re: Fix GUC_NO_SHOW_ALL test scenario in 003_check_guc.pl |
| Previous Message | Michael Banck | 2023-02-22 08:51:32 | Re: Amcheck verification of GiST and GIN |