Re: pg_dump insert column GENERATED

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Дмитрий Иванов <firstdismay(at)gmail(dot)com>
Cc: Adrian Klaver <adrian(dot)klaver(at)aklaver(dot)com>, pgsql-general <pgsql-general(at)lists(dot)postgresql(dot)org>
Subject: Re: pg_dump insert column GENERATED
Date: 2021-11-22 14:55:44
Message-ID: 3698208.1637592944@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-general

=?UTF-8?B?0JTQvNC40YLRgNC40Lkg0JjQstCw0L3QvtCy?= <firstdismay(at)gmail(dot)com> writes:
> Uchet=# select attname, attgenerated from pg_attribute
> Uchet-# where attrelid = 'bpd.object'::regclass and attnum > 0;
> attname | attgenerated
> -------------------------------+--------------
> id |
> id_class |
> id_position |
> ........pg.dropped.4........ |
> ........pg.dropped.5........ |
> ........pg.dropped.6........ |
> bquantity |
> ........pg.dropped.8........ |
> ........pg.dropped.9........ |
> id_position_root |
> id_conception |
> barcode_unit |
> id_unit_conversion_rule |
> ........pg.dropped.14........ |
> timestamp |
> on_freeze |
> timestamp_class |
> name |
> id_class_root |
> id_group |
> id_group_root |
> id_object_carrier |
> desc |
> ........pg.dropped.24........ |
> ........pg.dropped.25........ |
> ........pg.dropped.26........ |
> id_class_prop_object_carrier |
> id_pos_temp_prop |
> ........pg.dropped.29........ |
> mc |
> is_inside | s

Hah ... that gave me the clue I needed. If there are dropped
column(s) before the GENERATED one, pg_dump gets it wrong ---
but only in --inserts mode, not the default COPY mode, which
no doubt explains why nobody noticed. There is code in there
to inject DEFAULT, but it must be indexing the flag array wrong.

Will fix, thanks for the report!

regards, tom lane

In response to

Responses

Browse pgsql-general by date

  From Date Subject
Next Message Дмитрий Иванов 2021-11-22 15:12:11 Re: pg_dump insert column GENERATED
Previous Message Palani vel 2021-11-22 14:27:00 Doubt regarding Postgres replication issue