Re: pgsql: Allow db.schema.table patterns, but complain about random garbag

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: Robert Haas <rhaas(at)postgresql(dot)org>, pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Allow db.schema.table patterns, but complain about random garbag
Date: 2022-04-22 14:04:05
Message-ID: 3687648.1650636245@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
> This has upset the buildfarm's msys2 animals. There appears to be some
> wildcard expansion going on that causes the problem. I don't know why it
> should here when it's not causing trouble elsewhere. I have tried
> changing the way the tests are quoted, without success. Likewise,
> setting SHELLOPTS=noglob didn't work.

> At this stage I'm fresh out of ideas to fix it. It's also quite possible
> that my diagnosis is wrong.

When I was looking at this patch, I thought the number of test cases
was very substantially out of line anyway. I suggest that rather
than investing a bunch of brain cells trying to work around this,
we just remove the failing test cases.

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Andrew Dunstan 2022-04-22 14:24:27 Re: pgsql: Allow db.schema.table patterns, but complain about random garbag
Previous Message Andrew Dunstan 2022-04-22 13:15:31 Re: pgsql: Allow db.schema.table patterns, but complain about random garbag

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2022-04-22 14:14:23 Re: Dump/Restore of non-default PKs
Previous Message Bharath Rupireddy 2022-04-22 14:02:07 Re: How to generate a WAL record spanning multiple WAL files?