Re: Aw: Re: Minor documentation error regarding streaming replication protocol

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: Brar Piening <Brar(at)gmx(dot)de>, Michael Paquier <michael(at)paquier(dot)xyz>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Aw: Re: Minor documentation error regarding streaming replication protocol
Date: 2020-10-15 15:18:33
Message-ID: 3682335.1602775113@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Bruce Momjian <bruce(at)momjian(dot)us> writes:
> On Thu, Oct 15, 2020 at 10:03:46AM -0400, Tom Lane wrote:
>> I don't really see why our only documentation choices are "text" or
>> "bytea". Can't we just write "(raw file contents)" or the like?

> Agreed. The reason they are those labels is that the C code has to
> label the output fields, so it can only use SQL types. There are many
> protocol fields mislabeled in this way, not just timeline history.

Ah, right. Well, let's label it as text and then in the description
of the message, note that the field contains the raw file contents,
whose encoding is unknown to the server.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Stephen Frost 2020-10-15 15:31:16 Re: [Patch] Using Windows groups for SSPI authentication
Previous Message Alvaro Herrera 2020-10-15 15:17:50 Re: Logical Replication - detail message with names of missing columns