Re: configure.in / xml / quoting trouble

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Patrick Welche <prlw1(at)newn(dot)cam(dot)ac(dot)uk>
Cc: Andrew Dunstan <andrew(at)dunslane(dot)net>, pgsql-patches(at)postgresql(dot)org
Subject: Re: configure.in / xml / quoting trouble
Date: 2007-06-29 16:35:44
Message-ID: 3682.1183134944@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Patrick Welche <prlw1(at)newn(dot)cam(dot)ac(dot)uk> writes:
> On Thu, Jun 28, 2007 at 04:16:37PM -0400, Tom Lane wrote:
>> What exactly does xml2-config --libs produce on your machine?

> -Wl,-R/usr/local/lib -L/usr/local/lib -lxml2 -lz -lpthread -lm

> but because I added the -R - it isn't the default as distributed,

Hm. This doesn't seem like a bright way to be forcing an rpath.
The problem is that you have no idea what search order will result
when this is combined with any -R we ourselves might have included
or will later include into our LDFLAGS. As an example of possible
breakage, suppose you are trying to install PG into /opt/postgres
and there is already an old version of PG in /usr/local. You've
got about a fifty-fifty chance whether the produced binaries will
search /opt/postgres/lib before or after /usr/local/lib --- and
the second way is wrong, because they'd find the old version of
libpq.so.

Ugly as it sounds, I think you'd be better off setting the entire
Postgres rpath by hand by specifying LDFLAGS to configure.

The other thing that's a bit strange here is the reference to
libpthread --- does libxml2 really depend on that? I'd definitely
advise against linking libpthread into the backend if you can
avoid it.

regards, tom lane

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Alvaro Herrera 2007-06-29 17:19:29 Re: Cancel autovacuum conflicting with DROP TABLE
Previous Message Tom Lane 2007-06-29 16:24:09 Re: configure.in / xml / quoting trouble