Re: lz4 --rm on Ubuntu 18.04 (Add LZ4 compression to pg_dump)

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: Justin Pryzby <pryzby(at)telsasoft(dot)com>
Cc: Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, Christoph Berg <myon(at)debian(dot)org>, Tomas Vondra <tomas(dot)vondra(at)postgresql(dot)org>, Jacob Champion <jchampion(at)timescale(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: lz4 --rm on Ubuntu 18.04 (Add LZ4 compression to pg_dump)
Date: 2023-04-06 18:40:55
Message-ID: 367105C9-D199-4D0A-B3D4-B07113440065@yesql.se
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

> On 6 Apr 2023, at 18:39, Justin Pryzby <pryzby(at)telsasoft(dot)com> wrote:

> *If* you wanted to do something to fix this, you could create a key
> called files_to_remove_after_loading, and run unlink on those files
> rather than running a shell command. Or maybe just remove the file
> unconditionally at the start of the script ?

Since the test is written in Perl, and Perl has a function for deleting files
which abstracts the platform differences, using it seems like a logical choice?
{cleanup_cmd} can be replaced with {cleanup_files} with an unlink called on
that?

--
Daniel Gustafsson

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2023-04-06 19:52:55 pgsql: Fix ts_headline() edge cases for empty query and empty search te
Previous Message Andres Freund 2023-04-06 18:28:41 pgsql: hio: Don't pin the VM while holding buffer lock while extending

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Dunstan 2023-04-06 18:52:51 Re: what should install-world do when docs are not available?
Previous Message Justin Pryzby 2023-04-06 18:20:41 Re: cataloguing NOT NULL constraints