Re: Regression tests fail with musl libc because libpq.so can't be loaded

From: walther(at)technowledgy(dot)de
To: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Peter Eisentraut <peter(at)eisentraut(dot)org>
Cc: Christophe Pettus <xof(at)thebuild(dot)com>, Andrew Dunstan <andrew(at)dunslane(dot)net>, PostgreSQL Bugs <pgsql-bugs(at)lists(dot)postgresql(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Bruce Momjian <bruce(at)momjian(dot)us>
Subject: Re: Regression tests fail with musl libc because libpq.so can't be loaded
Date: 2024-03-21 20:30:00
Message-ID: 36690fcf-f0c8-4d60-af49-6a7efa0e2b14@technowledgy.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-hackers

Here is what we could with this:

> 2. The next proposal was to stop clobbering environ once LD_LIBRARY_PATH
> / LD_PRELOAD is found to keep those intact.

We could backpatch this down to v12. This would be one step to make the
test suite pass on Alpine Linux with musl and ultimately allow setting
up a buildfarm animal for that.

It does not solve the /proc/.../environ problem, but at least keeps ps
status working on musl as it did before, so not a regression.

> 4. The upstream (musl) suggestion of which I sent a PoC was to "exec
> yourself with a bigger argv".

We could do this in HEAD now ...

> Could we even use the exec-approach as the fallback in all other cases
> except BSDs and Windows and get rid of PS_USE_NONE?

... and then remove PS_USE_NONE at the beginning of the v18 cycle.

This would give a bit more time for those "other systems", which were
previously falling back PS_USE_NONE and would then clobber argv, too.

Opinions?

Best,

Wolfgang

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Thomas Munro 2024-03-21 22:42:52 Re: Regression tests fail with musl libc because libpq.so can't be loaded
Previous Message Wolfgang Walther 2024-03-21 20:16:46 Re: Regression tests fail with musl libc because libpq.so can't be loaded

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2024-03-21 20:31:45 Re: Slow GRANT ROLE on PostgreSQL 16 with thousands of ROLEs
Previous Message Wolfgang Walther 2024-03-21 20:16:46 Re: Regression tests fail with musl libc because libpq.so can't be loaded