Re: pgsql: Fix collprovider of predefined collations

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Fix collprovider of predefined collations
Date: 2017-06-13 13:54:19
Message-ID: 365.1497362059@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Peter Eisentraut <peter_e(at)gmx(dot)net> writes:
> Fix collprovider of predefined collations
> An earlier version of the patch had collprovider as an integer and thus
> set these to 0, but the correct setting is now null.

Surely this is not right. Neither collprovider nor the other fixed-length
fields following it in pg_collation are marked nullable, and most of them
are accessed as struct fields so that's not an easy thing to change.

The fact that the buildfarm didn't blow up is a bit odd. Maybe we're
missing some enforcement somewhere?

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Eisentraut 2017-06-13 14:44:07 pgsql: Improve code comments
Previous Message Peter Eisentraut 2017-06-13 13:14:34 pgsql: Use correct ICU path for Windows 32 vs. 64 bit