| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
| Cc: | jian he <jian(dot)universality(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Tender Wang <tndrwang(at)gmail(dot)com> |
| Subject: | Re: not null constraints, again |
| Date: | 2024-11-08 16:26:11 |
| Message-ID: | 3649828.1731083171@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> writes:
> But we'll see what else the buildfarm has to say now that I pushed it ...
A lot of the buildfarm is saying
adder | 2024-11-08 13:04:39 | ../pgsql/src/backend/catalog/pg_constraint.c:708:37: warning: comparison is always true due to limited range of data type [-Wtype-limits]
which evidently is about this:
Assert(colnum > 0 && colnum <= MaxAttrNumber);
The memcpy right before that doesn't seem like project style either.
Most other places that are doing similar things just cast the
ARR_DATA_PTR to the right pointer type and dereference it.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Previous Message | Tom Lane | 2024-11-08 15:42:59 | Re: [BUG] Fix DETACH with FK pointing to a partitioned table fails |