Re: [pgsql-hackers-win32] snprintf causes regression

Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
>> I'm not sure that macros can have variable number of arguments on all
>> supported platforms. I've been burnt by this before.

> The actual patch is:

> + #ifdef __GNUC__
> + #define vsnprintf(...) pg_vsnprintf(__VA_ARGS__)
> + #define snprintf(...) pg_snprintf(__VA_ARGS__)
> + #define printf(...) pg_printf(__VA_ARGS__)
> + #else
> + #define vsnprintf pg_vsnprintf
> + #define snprintf pg_snprintf
> + #define printf pg_printf
> + #endif

Uh, why bother with the different approach for gcc?

Also, what happened to fprintf? We're going to need that too for
localization of the client programs.

regards, tom lane