| From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
|---|---|
| To: | Sergei Kornilov <sk(at)zsrv(dot)org>, Stephen Frost <sfrost(at)snowman(dot)net> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, Postgres hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pgsql: Integrate recovery.conf into postgresql.conf |
| Date: | 2018-11-27 12:29:27 |
| Message-ID: | 362e291f-2442-3bbf-62f5-dde97beb3940@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On 27/11/2018 10:10, Sergei Kornilov wrote:
> Hello
>
>>> - recovery_target = immediate was replaced with recovery_target_immediate bool GUC
>>
>> Why?
> Due this comment: https://www.postgresql.org/message-id/20181126172118.GY3415%40tamriel.snowman.net
>> I've not been following this very closely, but seems like
>> recovery_target_string is a bad idea.. Why not just make that
>> 'recovery_target_immediate' and make it a boolean? Having a GUC that's
>> only got one valid value seems really odd.
It is a bit odd, but that's the way it's been, and I don't see a reason
to change it as part of this fix. We are attempting to fix the way the
GUC parameters are parsed, not change the name and meaning of the
parameters themselves.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2018-11-27 12:45:20 | Re: pgsql: Integrate recovery.conf into postgresql.conf |
| Previous Message | Sergei Kornilov | 2018-11-27 09:10:27 | Re: pgsql: Integrate recovery.conf into postgresql.conf |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2018-11-27 12:34:40 | Re: Use durable_unlink for .ready and .done files for WAL segment removal |
| Previous Message | David Steele | 2018-11-27 12:21:58 | Re: Continue work on changes to recovery.conf API |