From: | "Bossart, Nathan" <bossartn(at)amazon(dot)com> |
---|---|
To: | Noah Misch <noah(at)leadboat(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Invalidate acl.c caches for pg_authid.rolinherit changes |
Date: | 2020-12-21 19:01:51 |
Message-ID: | 3626D6A6-0CEB-43CA-8228-A17BD888876E@amazon.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 12/21/20, 1:51 AM, "Noah Misch" <noah(at)leadboat(dot)com> wrote:
> Backends reflect "GRANT role_name" changes rather quickly, due to a syscache
> invalidation callback. Let's register an additional callback to reflect
> "ALTER ROLE ... [NO]INHERIT" with equal speed. I propose to back-patch this.
> While pg_authid changes may be more frequent than pg_auth_members changes, I
> expect neither is frequent enough to worry about the resulting acl.c cache
> miss rate.
+1 to back-patching.
> pg_authid changes don't affect cached_membership_roles, so I could have
> invalidated cached_privs_roles only. That felt like needless complexity. I
> expect cached_privs_role gets the bulk of traffic, since SELECT, INSERT,
> UPDATE and DELETE use it. cached_membership_roles pertains to DDL and such.
The patch looks reasonable to me.
Nathan
From | Date | Subject | |
---|---|---|---|
Next Message | Stephen Frost | 2020-12-21 19:06:08 | Re: BUG #16079: Question Regarding the BUG #16064 |
Previous Message | Stephen Frost | 2020-12-21 18:53:19 | Re: BUG #16079: Question Regarding the BUG #16064 |