Re: Git revision in tarballs

Magnus Hagander <magnus(at)hagander(dot)net> writes:
> Putting it in the tarball making script certainly works for me,
> though, if that's what people prefer. And that does away with the
> "clean" part as that one blows away the whole directory between each
> run.

Actually, we *have* to do it over there, because what that script
does is

# Export the selected git ref
git archive ${i} | tar xf - -C pgsql

cd pgsql
./configure
# some irrelevant stuff
make dist

So there's no .git subdirectory in the directory it runs "make dist"
in. Now maybe it'd work anyway because of the GIT_DIR environment
variable, but what I think is more likely is that the file would
end up containing the current master-branch HEAD commit, whereas
the thing we actually want to record here is ${i}.

regards, tom lane