Re: Fixup a few 2023 copyright years

David Rowley <dgrowleyml(at)gmail(dot)com> writes:
> Attached is a patch which adjusts the copyright years of 2023 that
> have crept in this year from patches that were written last year and
> committed without adjusting this to 2024.

> The patch isn't produced by src/tools/copyright.pl as that'll
> transform files which are new and only contain "2023" to become
> "2023-2024", which I don't believe is what we want in this case.

Agreed, copyright.pl is not quite the right tool, although you could
use its output as a starting point and manually adjust any wrong
changes.

> Should we do this and is this a good time to?

We *should* do this sometime before branching v17, but I'm not
in any hurry. My thought here is that some of these late changes
might end up getting reverted, in which case touching those files
would add a bit more complexity to the revert. We can do this
sort of mechanical cleanup after the probability of reversion has
declined a bit.

(On the same logic, I'm resisting the temptation to do a tree-wide
pgindent right away. Yeah, the tree is indent-clean according to
the current contents of src/tools/pgindent/typedefs.list, but that
hasn't been maintained with great accuracy, so we'll need an
update and then a pgindent run at some point.)

regards, tom lane