Re: BUG #18274: Error 'invalid XML content'

From: Dmitry Koval <d(dot)koval(at)postgrespro(dot)ru>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-bugs(at)lists(dot)postgresql(dot)org
Subject: Re: BUG #18274: Error 'invalid XML content'
Date: 2024-01-15 15:47:17
Message-ID: 35ef78f9-8958-4225-ae7e-aead71b0feed@postgrespro.ru
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

Hi!

> Knowing that we have full control of the memory contexts for the XML
> nodes, just enforcing the huge flag does not seem like there's any
> downside for us. (Right?)

I think that's right (flag XML_PARSE_HUGE shouldn't cause any problems).
My main doubts are related to the replacement of the
xmlParseBalancedChunkMemory() function (that haven't argument for pass
XML_PARSE_HUGE flag) with xmlNewNode() + xmlParseInNodeContext()
functions (create a fake node and pass the XML_PARSE_HUGE flag to
xmlParseInNodeContext function).

I'm not sure if this replacement is 100% equivalent (although simple
tests work the same).

--
With best regards,
Dmitry Koval

Postgres Professional: http://postgrespro.com

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Robert Haas 2024-01-15 16:08:58 Re: BUG #17798: Incorrect memory access occurs when using BEFORE ROW UPDATE trigger
Previous Message Devrim Gündüz 2024-01-15 15:23:21 Re: BUG #18289: postgresql14-devel-14.10-2PGDG.rhel8.x86_64.rpm Contains invalid cLang option in Makefile.global