| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, pgsql-committers <pgsql-committers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: pgsql: xlog.c: Remove global variables ReadRecPtr and EndRecPtr. |
| Date: | 2021-11-26 04:02:49 |
| Message-ID: | 359621.1637899369@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> On Wed, Nov 24, 2021 at 8:01 PM Andres Freund <andres(at)anarazel(dot)de> wrote:
>> Pushed the obvious fix for that. Somehow thought I'd seen more compile failure
>> than the one WAL_DEBUG...
> Hmm, thanks. I guess i put too much trust in the compiler.
My approach to such patches is always "in grep we trust, all others
pay cash". Even without #ifdef issues, you are highly likely to
miss comments that need to be updated.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2021-11-26 09:01:22 | pgsql: Update comments |
| Previous Message | Robert Haas | 2021-11-26 01:30:48 | Re: pgsql: xlog.c: Remove global variables ReadRecPtr and EndRecPtr. |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Greg Nancarrow | 2021-11-26 04:07:36 | Re: row filtering for logical replication |
| Previous Message | torikoshia | 2021-11-26 03:39:48 | Re: RFC: Logging plan of the running query |