| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | John Gorman <johngorman2(at)gmail(dot)com> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Incompatible trig error handling |
| Date: | 2015-04-30 00:11:48 |
| Message-ID: | 35777.1430352708@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
John Gorman <johngorman2(at)gmail(dot)com> writes:
> Two of the trigonometry functions have differing error condition behavior
> between Linux and OSX. The Linux behavior follows the standard set by the
> other trig functions.
We have never considered it part of Postgres' charter to try to hide
platform-specific variations in floating-point behavior. If we did,
we'd spend all our time doing that rather than more productive stuff.
In particular, it appears to me that both of these behaviors are allowed
per the POSIX standard, which makes it very questionable why we should
insist that one is correct and the other is not.
In addition, the proposed patch turns *all* cases that return NaN into
errors, which is wrong at least for the case where the input is NaN.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2015-04-30 00:20:04 | Re: Additional role attributes && superuser review |
| Previous Message | Andres Freund | 2015-04-30 00:07:30 | Re: Final Patch for GROUPING SETS |