Re: Audit of logout

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
Cc: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, Magnus Hagander <magnus(at)hagander(dot)net>, Joe Conway <mail(at)joeconway(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Audit of logout
Date: 2014-09-14 01:06:26
Message-ID: 3529.1410656786@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> writes:
> Yes, it was failing only on windows. Today when I further tried to
> look into the issue, I found that if I rebuild plpgsql, it didn't occurred.
> So the conclusion is that it occurred due to build mismatch, however I
> am not sure why a rebuild of plpgsql is required for this patch.
> Sorry for the noise.

plpgsql contains references to PGC_SUSET and PGC_USERSET, whose values are
changed by this patch, so failure is unsurprising if you don't rebuild it.
(I saw failures in the regression tests even without Windows until I
updated plpgsql.)

Committed with minor cosmetic adjustments; mostly, rewriting some
comments.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message ktm@rice.edu 2014-09-14 01:27:51 Re: [REVIEW] Re: Compression of full-page-writes
Previous Message Arthur Silva 2014-09-14 00:50:55 Re: [REVIEW] Re: Compression of full-page-writes